IT-4204: Add IAM permissions to llm dev role #1337
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xschildw
commented
Feb 13, 2025
| "Resource": "arn:aws:iam::${AWS::AccountId}:role/synllmrole-*", | ||
| "Condition": { | ||
| "StringEquals": { | ||
| "iam:PermissionsBoundary": "${synLlmLambdaExecPermissionBoundary}" |
There was a problem hiding this comment.
ARN of boundary policy needs to be set here (had both resources in same template in original code).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds IAM permissions to create roles and policies to the LLM developer role.
Depends on #1336 to be deployed.
The boundary is included when determining the effective permissions at runtime, it is required when
creating a role (and there is no check on the policy attached to the role).
See https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_boundaries.html