[IT-4089] Suppress access-key rotation for service users #1390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't require the Bridge service users to rotate access keys every 90 days. A lack of certainty around knowing all locations to update creates a risk of a prolonged outage with data loss. Also refactor suppression for credentials unused for 45 days so that it is also restricted to the Bridge service users.
zaro0508
approved these changes
Apr 22, 2025
|
Yeah, I would love to move to OIDC, but Bridge is still using Travis so it's not worth the effort. |
xschildw
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't require the Bridge service users to rotate access keys every 90 days. A lack of certainty around knowing all locations to update creates a risk of a prolonged outage with data loss.
Also refactor suppression for credentials unused for 45 days so that it is also restricted to the Bridge service users.