Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(agora): centralize the task definition build-image (ARCH-307) #2892

Merged
merged 3 commits into from
Oct 11, 2024
Merged

feat(agora): centralize the task definition build-image (ARCH-307) #2892

merged 3 commits into from
Oct 11, 2024

Conversation

tschaffter
Copy link
Member

@tschaffter tschaffter commented Oct 11, 2024 •
edited
Loading

Closes https://sagebionetworks.jira.com/browse/ARCH-307

Changelog

  • Update the Nx plugin to support Agora apps
  • Remove the task build-image from the project.json files

Preview

The Agora apps can still be dockerized even if their project.json files no longer define the task build-image, which is now defined in the Sage Monorepo Nx plugin.

$ agora-build-images
$ docker images
REPOSITORY                                TAG           IMAGE ID       CREATED          SIZE
ghcr.io/sage-bionetworks/agora-data       local         fa10d1fc58fb   5 seconds ago    219MB
ghcr.io/sage-bionetworks/agora-data       sha-f70dfb0   fa10d1fc58fb   5 seconds ago    219MB
ghcr.io/sage-bionetworks/agora-api        local         95eb65d77850   26 seconds ago   141MB
ghcr.io/sage-bionetworks/agora-api        sha-f70dfb0   95eb65d77850   26 seconds ago   141MB
ghcr.io/sage-bionetworks/agora-app        local         00c92e252e9b   31 seconds ago   203MB
ghcr.io/sage-bionetworks/agora-app        sha-f70dfb0   00c92e252e9b   31 seconds ago   203MB
ghcr.io/sage-bionetworks/agora-api-docs   local         a7c7cc7b2308   49 seconds ago   57.2MB
ghcr.io/sage-bionetworks/agora-api-docs   sha-f70dfb0   a7c7cc7b2308   49 seconds ago   57.2MB
ghcr.io/sage-bionetworks/agora-apex       local         ad4141811ecd   4 months ago     49.2MB
ghcr.io/sage-bionetworks/agora-apex       sha-f70dfb0   ad4141811ecd   4 months ago     49.2MB
ghcr.io/sage-bionetworks/agora-mongo      local         449de6550138   22 months ago    700MB
ghcr.io/sage-bionetworks/agora-mongo      sha-f70dfb0   449de6550138   22 months ago    700MB

@tschaffter tschaffter self-assigned this Oct 11, 2024
@tschaffter
Copy link
Member Author

tschaffter commented Oct 11, 2024 •
edited
Loading

Error when building the image of agora-api

 NX   buildx failed with: ERROR: failed to solve: failed to compute cache key: failed to calculate checksum of ref a266a31c-4b21-4625-89b7-d0f79094aa1b::xc40b78uty41dalitu9vpfmir: "/dist/apps/agora/api": not found

@tschaffter tschaffter marked this pull request as ready for review October 11, 2024 16:26
@tschaffter tschaffter requested a review from a team as a code owner October 11, 2024 16:26
@tschaffter tschaffter changed the title feat(agora): centralize the task definition build-image feat(agora): centralize the task definition build-image (ARCH-307) Oct 11, 2024
sagely1
sagely1 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@sagely1 sagely1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran nx build on a few projects as well as agora-build-images to test. Other than renaming of a function everything LGTM!

@tschaffter tschaffter enabled auto-merge October 11, 2024 21:53
@tschaffter tschaffter disabled auto-merge October 11, 2024 22:15
@tschaffter tschaffter requested a review from sagely1 October 11, 2024 22:15
@tschaffter tschaffter enabled auto-merge October 11, 2024 22:16
@tschaffter tschaffter added this pull request to the merge queue Oct 11, 2024
Merged via the queue into Sage-Bionetworks:main with commit e2ecb1f Oct 11, 2024
9 checks passed
@tschaffter tschaffter deleted the agora/centralize-build-image-task branch October 11, 2024 22:18
sagely1 pushed a commit to sagely1/sage-monorepo that referenced this pull request Nov 26, 2024
@tschaffter @sagely1
feat(agora): centralize the task definition build-image (ARCH-307) (S…
dc7c0cd 
…age-Bionetworks#2892)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagely1 sagely1 sagely1 approved these changes

Assignees

@tschaffter tschaffter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tschaffter @sagely1