Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update prettier to v3.3.3 - FE-6295 #6862

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

DipperTheDan
Copy link
Contributor

@DipperTheDan DipperTheDan commented Jul 26, 2024

Proposed behaviour

  • Update prettier to version 3.3.3
  • Run the latest version of prettier over the codebase

Current behaviour

Prettier is currently on version 2.x.x

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

N/A

Testing instructions

Probably best to give the important components a once over for any regressions. I think if the test suite passes and Chromatic passes too, we should be good but a physical QA will give us confidence this change hasn't broken anything that requires manual testing.

Parsium
Parsium previously approved these changes Jul 29, 2024
paulrobinson88
paulrobinson88 previously approved these changes Aug 14, 2024
Parsium
Parsium previously approved these changes Aug 19, 2024
@DipperTheDan DipperTheDan changed the title chore: update prettier to v3.3.3 chore: update prettier to v3.3.3 - FE-6295 Oct 30, 2024
Parsium
Parsium previously approved these changes Oct 30, 2024
paulrobinson88
paulrobinson88 previously approved these changes Oct 30, 2024
@DipperTheDan DipperTheDan merged commit b1725e3 into master Oct 31, 2024
24 checks passed
@DipperTheDan DipperTheDan deleted the update-prettier-to-latest branch October 31, 2024 14:56
@carbonci
Copy link
Collaborator

carbonci commented Nov 5, 2024

🎉 This PR is included in version 144.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants