Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inline label props have unexpected behavior with new validation #7015

Merged
merged 9 commits into from
Oct 29, 2024
Merged

fix: inline label props have unexpected behavior with new validation #7015

merged 9 commits into from
Oct 29, 2024

Conversation

mihai-albu-sage
Copy link
Contributor

@mihai-albu-sage mihai-albu-sage commented Oct 11, 2024 •
edited
Loading

labelInline and legendInline should have no effect with new validation

Proposed behaviour

labelInline or legendInline props should have no effect when new validation flag has been set across the following components: DateRange, NumeralDate, RadioButtonGroup, Textarea

DateRange with new validation flag and labelInline - proposed behavior:
date range with labelInline - after

NumeralDate with new validation flag and labelInline - proposed behavior:
numeral date with labelInline - after

RadioButtonGroup with new validation flag and legendInline - proposed behavior:
radio button with legendInline - after

Textarea with ``new validation flag and labelInline - proposed behavior: (no padding-top present that shifts the entire content down).
textarea with labelInline - after

Current behaviour

In certain components, labelInline or legendInline props change the component alignment when the new validation flag has been set.

DateRange with new validation flag and labelInline - current behavior:
date range with labelInline - before

NumeralDate with new validation flag and labelInline - current behavior:
numeral date with labelInline - before

RadioButtonGroup with new validation flag and legendInline - current behavior:
radio button with legendInline - before

Textarea with ``new validation flag and labelInline - current behavior: (padding-top is present and shifts the entire content down)
textarea with labelInline - before

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@mihai-albu-sage mihai-albu-sage self-assigned this Oct 11, 2024
@mihai-albu-sage mihai-albu-sage requested a review from a team as a code owner October 11, 2024 07:03
@mihai-albu-sage
fix: inline label props have unexpected behaviour with new validation
922694f 
labelInline and legendInline should have no effect with new validation
@DipperTheDan DipperTheDan self-requested a review October 16, 2024 13:30
@Parsium Parsium self-requested a review October 23, 2024 12:17
@Parsium Parsium marked this pull request as draft October 23, 2024 12:51
@DipperTheDan DipperTheDan removed their request for review October 24, 2024 07:54
@mihai-albu-sage mihai-albu-sage marked this pull request as ready for review October 24, 2024 08:05
@mihai-albu-sage mihai-albu-sage merged commit b6dc796 into master Oct 29, 2024
24 checks passed
@mihai-albu-sage mihai-albu-sage deleted the FE-6666 branch October 29, 2024 04:00
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 144.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulrobinson88 paulrobinson88 paulrobinson88 approved these changes

@edleeks87 edleeks87 edleeks87 approved these changes

@Parsium Parsium Parsium approved these changes

Assignees

@mihai-albu-sage mihai-albu-sage

Labels
Passed QA Passed Review released Squad Front End
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mihai-albu-sage @carbonci @Parsium @edleeks87 @paulrobinson88