Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(filterable-select): convert unit tests to RTL #7036

Merged
merged 1 commit into from
Oct 28, 2024
Merged

refactor(filterable-select): convert unit tests to RTL #7036

merged 1 commit into from
Oct 28, 2024

Conversation

edleeks87
Copy link
Contributor

Proposed behaviour

Converts FilterableSelect unit tests to RTL

Current behaviour

FilterableSelect unit tests are enzyme

Checklist

  • Commits follow our style guide
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@edleeks87 edleeks87 self-assigned this Oct 24, 2024
nuria1110
nuria1110 previously approved these changes Oct 28, 2024
View reviewed changes
@edleeks87 edleeks87 marked this pull request as ready for review October 28, 2024 12:41
@edleeks87 edleeks87 requested review from a team as code owners October 28, 2024 12:41
@edleeks87 edleeks87 merged commit 02a8c60 into master Oct 28, 2024
25 checks passed
@edleeks87 edleeks87 deleted the filterable-rtl branch October 28, 2024 12:50
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 144.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulrobinson88 paulrobinson88 paulrobinson88 approved these changes

@nuria1110 nuria1110 nuria1110 approved these changes

@damienrobson-sage damienrobson-sage damienrobson-sage approved these changes

Assignees

@edleeks87 edleeks87

Labels
No QA Required No UX QA Required Pending Review released Squad Front End
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@edleeks87 @carbonci @damienrobson-sage @nuria1110 @paulrobinson88