feat(multi-select, simple-select): add listActionButton & onListAction #7044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomdavies73
force-pushed
the
FE-6864
branch
3 times, most recently
from
a5b2fd4
to
a1de7e7
Compare
damienrobson-sage
approved these changes
Oct 28, 2024
edleeks87
reviewed
Oct 28, 2024
| @@ -284,6 +284,65 @@ export const MultiSelectMultiColumnsComponent = ( | |||
| ); | |||
| }; | |||
|
|
|||
| export const MultiSelectWithActionButtonComponent = () => { | |||
There was a problem hiding this comment.
suggestion (non-blocking): might be worth just using the list action button to add the new options so it's a bit simpler, opening a dialog seems a bit left field to me
There was a problem hiding this comment.
Leave this for now until we've had confirmation about how it should behave when the button is clicked
| @@ -365,6 +424,29 @@ export const MultiSelectCustomColorComponent = ( | |||
| ); | |||
| }; | |||
|
|
|||
| export const MultiSelectListActionEventComponent = ( | |||
| props: Partial<MultiSelectProps> | |||
There was a problem hiding this comment.
suggestion (non-blocking): you could make onListAction Required here so it's flagged if someone ever uses it and doesn't pass the callback etc
| @@ -529,6 +547,11 @@ export const MultiSelect = React.forwardRef<HTMLInputElement, MultiSelectProps>( | |||
| isMouseDownReported.current = true; | |||
| } | |||
|
|
|||
| function handleOnListAction() { | |||
| setOpenState(false); | |||
There was a problem hiding this comment.
Question: as the list closes when the button is clicked, will this really work for lazy loading?
@harpalsingh fyi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6752
Proposed behaviour
Adds the
listActionButtonprop andonListActioncallback to theMultiSelectandSimpleSelectcomponents.Current behaviour
Currently, only
FilterableSelecthas thelistActionButtonprop andonListActioncallback.Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions