Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove aria-checked from checkbox/radio inputs #7062

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Conversation

tomdavies73
Copy link
Contributor

fix #7047

Proposed behaviour

Removes the aria-checked attribute from the codebase when applied to checkbox/radio inputs, and instead leverages the built-in semantics of these input types, aligning with best practices.

Current behaviour

Currently, aria-checked is used on checkbox/radio inputs, which is unnecessary.

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@Parsium Parsium marked this pull request as ready for review November 7, 2024 14:22
@tomdavies73 tomdavies73 merged commit 8d93e77 into master Nov 8, 2024
44 checks passed
@tomdavies73 tomdavies73 deleted the FE-6882 branch November 8, 2024 15:33
@carbonci
Copy link
Collaborator

carbonci commented Nov 8, 2024

🎉 This PR is included in version 144.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

TileSelect sometimes triggers AXE Critical Issue for aria-checked attribute on radio / checkbox
5 participants