fix(multi-action-button, split-button): ensure screen reader commands can navigate menu popup #7074
+151
−220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DipperTheDan
previously approved these changes
Nov 14, 2024
edleeks87
reviewed
Nov 14, 2024
| @@ -679,49 +643,6 @@ test("should hide the additional buttons when a 'Escape' keydown event detected | |||
| expect(screen.queryByRole("list")).not.toBeInTheDocument(); | |||
| }); | |||
|
|
|||
| test("should render with the correct styles when 'align' prop is 'right'", async () => { | |||
There was a problem hiding this comment.
question: are testing this stuff anywhere else? I think PW would be better until we have play functions implemented but unit tests will also be okay in the interim etc
There was a problem hiding this comment.
Removed these as they seemed to be pretty much the same as the tests here
There was a problem hiding this comment.
Also looks like we have PW tests too
There was a problem hiding this comment.
nice one thanks for checking
| ); | ||
|
|
||
| // check if a child button is focused, if not hide the menu | ||
| const checkFocus = useCallback(() => { | ||
| const buttonChildren = getButtonChildren(); |
There was a problem hiding this comment.
suggestion (non-blocking): You could short-circuit the function or conditionally assign you can avoid checking it's truthyness on line 91
if (!buttonChildren) return;
or
const buttonChildren = getButtonChildren() || [] ;
… can navigate menu popup Fixes issue where screen reader users using VoiceOver could not navigate into the menu buttons using commands VO+Space to open the menu then VO+right to navigate. The first option will now gain focus on open using any interaction method, including onClick, keyboard navigation and screen reader controls. fix #7054
edleeks87
approved these changes
Nov 15, 2024
DipperTheDan
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7054
Proposed behaviour
Current behaviour
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
Best tested in an example containing several focusable elements e.g.: "Sizes" story.