Update aeon_mecha using the new swc.aeon package
#461
Conversation
There was a problem hiding this comment.
Thanks @ttngu207 ! Only a few minor comments and we can discuss introducing the swc namespace in a separate issue/PR.
| @@ -24,18 +24,14 @@ dependencies = [ | |||
| "bottleneck>=1.2.1,<2", | |||
| "datajoint>=0.13.7", | |||
| "datajoint-utilities @ git+https://github.com/datajoint-company/datajoint-utilities", | |||
| "dotmap", | |||
| "swc-aeon @ git+https://github.com/SainsburyWellcomeCentre/aeon_api.git", | |||
There was a problem hiding this comment.
| "swc-aeon @ git+https://github.com/SainsburyWellcomeCentre/aeon_api.git", | |
| "swc-aeon", |
use pypi swc-aeon?
There was a problem hiding this comment.
Yeah, I wasn't sure the overall status of swc-aeon package, hence the install from github. We could easily switch to pypi
| import swc.aeon.io.reader as io_reader | ||
| from swc.aeon.io import api as io_api |
There was a problem hiding this comment.
| import swc.aeon.io.reader as io_reader | |
| from swc.aeon.io import api as io_api | |
| from swc.aeon.io import api as io_api | |
| from swc.aeon.io import reader as io_reader |
There was a problem hiding this comment.
Agreed, but somehow, ruff put those in that order
| @@ -8,9 +8,11 @@ | |||
| import datajoint as dj | |||
| import pandas as pd | |||
|
|
|||
| import swc | |||
There was a problem hiding this comment.
| import swc | |
| import swc | |
| from swc.aeon.io import api as io_api | |
| from swc.aeon.io import reader as io_reader |
| from swc.aeon.io import api as io_api | ||
| from swc.aeon.io import reader as io_reader |
There was a problem hiding this comment.
| from swc.aeon.io import api as io_api | |
| from swc.aeon.io import reader as io_reader |
| reader = {"swc": swc, "aeon": aeon} | ||
| for idx, n in enumerate(stream_detail["stream_reader"].split(".")): | ||
| reader = reader[n] if idx == 0 else getattr(reader, n) |
There was a problem hiding this comment.
do we still have any readers in aeon? could we just have reader = swc.aeon and getattr(reader, module path after "aeon." )
There was a problem hiding this comment.
We do, in aeon we still may create new Stream with new Reader based on the existing readers in swc
aeon.iotestsswc.aeoninsteaddj_pipelineingestions to usingswc.aeonpackageWhat's next: update test suite for
dj_pipeline(probably a separate PR)