Skip to content

(#117) Organizations service - endpoints fix #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@ public async Task HandleAsync(AddOrganizerToOrganization command, CancellationTo
{
throw new OrganizationNotFoundException(command.OrganizationId);
}

var organizer = await _organizerRepository.GetAsync(command.OrganizerId);
if (organizer is null)
{
throw new OrganizerNotFoundException(command.OrganizerId);
}

organization.AddOrganizer(organizer);
organization.AddOrganizer(command.OrganizerId);
await _organizationRepository.UpdateAsync(organization);
await _messageBroker.PublishAsync(new OrganizerAddedToOrganization(organization.Id, organizer.Id));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public async Task HandleAsync(RemoveOrganizerFromOrganization command, Cancellat
throw new OrganizerNotFoundException(command.OrganizerId);
}

organization.RemoveOrganizer(organizer);
organization.RemoveOrganizer(organizer.Id);
await _organizationRepository.UpdateAsync(organization);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public async Task HandleAsync(OrganizerRightsRevoked @event, CancellationToken c
var organizerOrganizations = await _organizationRepository.GetOrganizerOrganizationsAsync(@event.UserId);
foreach (var organization in organizerOrganizations)
{
organization.RemoveOrganizer(organizer);
organization.RemoveOrganizer(organizer.Id);
await _organizationRepository.UpdateAsync(organization);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,26 +24,23 @@ public Organization(Guid id, string name, Guid parentId, bool isLeaf = true, IEn
Organizers = organizers ?? Enumerable.Empty<Organizer>();
}

public void RemoveOrganizer(Organizer organizer)
=> _organizers.Remove(organizer);

public void RemoveOrganizer(Guid organizerId)
{
var organizer = _organizers.SingleOrDefault(x => x.Id == organizerId);
if(organizer is null)
{
throw new OrganizerIsNotInOrganization(organizerId, Id);
}
RemoveOrganizer(organizer);
_organizers.Remove(organizer);
}

public void AddOrganizer(Organizer organizer)
public void AddOrganizer(Guid organizerId)
{
if(Organizers.Contains(organizer))
if(Organizers.Any(x => x.Id == organizerId))
{
throw new OrganizerAlreadyAddedToOrganizationException(organizer.Id, Id);
throw new OrganizerAlreadyAddedToOrganizationException(organizerId, Id);
}
_organizers.Add(organizer);
_organizers.Add(new Organizer(organizerId));
}


Expand Down