-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#125) notifications service implementation -- external events arrangement. #140
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #140 +/- ##
=======================================
Coverage 33.63% 33.63%
=======================================
Files 65 65
Lines 877 877
Branches 82 82
=======================================
Hits 295 295
Misses 560 560
Partials 22 22 ☔ View full report in Codecov by Sentry. |
Wouldn't it be easier/better to create notifications by using external events and their handlers? I.e. if we want to create a notification that someone has invited you to be your friend, utilize a FriendInvited event from friends service. |
…e notification component
Providing the notification service implementation.