Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#125) notifications service implementation -- external events arrangement. #140

Merged
merged 121 commits into from
May 25, 2024

Conversation

SaintAngeLs
Copy link
Owner

@SaintAngeLs SaintAngeLs commented May 12, 2024

Providing the notification service implementation.

Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.63%. Comparing base (f9d98de) to head (5832a3f).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #140   +/-   ##
=======================================
  Coverage   33.63%   33.63%           
=======================================
  Files          65       65           
  Lines         877      877           
  Branches       82       82           
=======================================
  Hits          295      295           
  Misses        560      560           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eggwhat
Copy link
Contributor

eggwhat commented May 12, 2024

Wouldn't it be easier/better to create notifications by using external events and their handlers? I.e. if we want to create a notification that someone has invited you to be your friend, utilize a FriendInvited event from friends service.

@SaintAngeLs SaintAngeLs linked an issue May 24, 2024 that may be closed by this pull request
@SaintAngeLs SaintAngeLs merged commit b96ddb6 into dev May 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RelatedEntityId to Notification Entity Friends Service udpate Notifications service
3 participants