Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#305 add syncronisation with gitlab #309

Merged
merged 121 commits into from
Jul 21, 2024
Merged

#305 add syncronisation with gitlab #309

merged 121 commits into from
Jul 21, 2024

Conversation

SaintAngeLs
Copy link
Owner

Synchronisation with gitlab

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 0.21930% with 455 lines in your changes missing coverage. Please review.

Project coverage is 68.53%. Comparing base (4330690) to head (70b38f8).
Report is 7 commits behind head on main.

Files Patch % Lines
...y.Application/Services/Identity/IdentityService.cs 0.00% 196 Missing ⚠️
...Infrastructure/Auth/TwoFactorSecretTokenService.cs 0.00% 53 Missing ⚠️
.../MiniSpace.Services.Identity.Core/Entities/User.cs 2.22% 44 Missing ⚠️
...ty.Infrastructure/Auth/VerificationTokenService.cs 0.00% 21 Missing ⚠️
...ation/Commands/Handlers/DisableTwoFactorHandler.cs 0.00% 9 Missing ⚠️
...cation/Commands/Handlers/EnableTwoFactorHandler.cs 0.00% 9 Missing ⚠️
...ommands/Handlers/GenerateTwoFactorSecretHandler.cs 0.00% 9 Missing ⚠️
...pplication/Commands/Handlers/VerifyEmailHandler.cs 0.00% 9 Missing ⚠️
...vices.Identity.Application/Commands/VerifyEmail.cs 0.00% 9 Missing ⚠️
...vices.Identity.Application/Events/EmailVerified.cs 0.00% 9 Missing ⚠️
... and 14 more

❗ There is a different number of reports uploaded between BASE (4330690) and HEAD (70b38f8). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (4330690) HEAD (70b38f8)
16 12
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #309       +/-   ##
===========================================
- Coverage   86.59%   68.53%   -18.06%     
===========================================
  Files         328      265       -63     
  Lines        4140     3350      -790     
  Branches      352      283       -69     
===========================================
- Hits         3585     2296     -1289     
- Misses        440      970      +530     
+ Partials      115       84       -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

if (!string.IsNullOrEmpty(userId))
{
await Groups.AddToGroupAsync(Context.ConnectionId, userId);
_logger.LogInformation($"======================================================================================User {userId} connected with connection ID: {Context.ConnectionId}");

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarCloud
if (!string.IsNullOrEmpty(userId))
{
await Groups.RemoveFromGroupAsync(Context.ConnectionId, userId);
_logger.LogInformation($"User {userId} disconnected with connection ID: {Context.ConnectionId}");

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarCloud
@SaintAngeLs
Copy link
Owner Author

Test merge to mirror gitlab repo structure.

@SaintAngeLs SaintAngeLs merged commit 1c0ddef into main Jul 21, 2024
21 of 23 checks passed
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
3.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)
B Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant