Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#305 upate vulnerability check yml merge to dev #323

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

SaintAngeLs
Copy link
Owner

upate vulnerability check yml

Copy link

gitguardian bot commented Jul 22, 2024

⚠️ GitGuardian has uncovered 28 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13122842 Triggered Company Email Password 7301c43 MiniSpace.Services.Email/src/MiniSpace.Services.Email.Api/appsettings.docker.json View secret
13122842 Triggered Company Email Password 7301c43 MiniSpace.Services.Email/src/MiniSpace.Services.Email.Api/appsettings.local.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Organizations/src/MiniSpace.Services.Organizations.Api/appsettings.local.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Comments/src/MiniSpace.Services.Comments.Api/appsettings.docker.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Identity/src/MiniSpace.Services.Identity.Api/appsettings.docker.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Reports/src/MiniSpace.Services.Reports.Api/appsettings.local.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Notifications/src/MiniSpace.Services.Notifications.Api/appsettings.docker.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Identity/src/MiniSpace.Services.Identity.Api/appsettings.local.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Friends/src/MiniSpace.Services.Friends.Api/appsettings.docker.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Reactions/src/MiniSpace.Services.Reactions.Api/appsettings.docker.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.MediaFiles/src/MiniSpace.Services.MediaFiles.Api/appsettings.local.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Comments/src/MiniSpace.Services.Comments.Api/appsettings.local.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Students/src/MiniSpace.Services.Students.Api/appsettings.docker.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Reports/src/MiniSpace.Services.Reports.Api/appsettings.docker.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Events/src/MiniSpace.Services.Events.Api/appsettings.docker.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Events/src/MiniSpace.Services.Events.Api/appsettings.local.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Reactions/src/MiniSpace.Services.Reactions.Api/appsettings.local.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Students/src/MiniSpace.Services.Students.Api/appsettings.local.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Posts/src/MiniSpace.Services.Posts.Api/appsettings.docker.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Email/src/MiniSpace.Services.Email.Api/appsettings.docker.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Notifications/src/MiniSpace.Services.Notifications.Api/appsettings.local.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Friends/src/MiniSpace.Services.Friends.Api/appsettings.local.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.MediaFiles/src/MiniSpace.Services.MediaFiles.Api/appsettings.docker.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Posts/src/MiniSpace.Services.Posts.Api/appsettings.local.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Organizations/src/MiniSpace.Services.Organizations.Api/appsettings.docker.json View secret
13122843 Triggered MongoDB Credentials 7301c43 MiniSpace.Services.Email/src/MiniSpace.Services.Email.Api/appsettings.local.json View secret
13122844 Triggered SMTP credentials 7301c43 MiniSpace.Services.Email/src/MiniSpace.Services.Email.Api/appsettings.docker.json View secret
13122844 Triggered SMTP credentials 7301c43 MiniSpace.Services.Email/src/MiniSpace.Services.Email.Api/appsettings.local.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.53%. Comparing base (3a3ecb5) to head (7301c43).
Report is 11 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #323   +/-   ##
=======================================
  Coverage   68.53%   68.53%           
=======================================
  Files         265      265           
  Lines        3350     3350           
  Branches      283      283           
=======================================
  Hits         2296     2296           
  Misses        970      970           
  Partials       84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@SaintAngeLs SaintAngeLs merged commit 90a3d8d into dev Jul 22, 2024
31 of 33 checks passed
@SaintAngeLs SaintAngeLs deleted the notification_service_update branch July 22, 2024 16:06
@SaintAngeLs SaintAngeLs restored the notification_service_update branch July 22, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant