@W-17526051 - Add a "Back" button for Standard Login #2208
Conversation
jeremy-jung1
changed the title
| "login_form.button.back": [ | ||
| { | ||
| "type": 0, | ||
| "value": "Back" |
There was a problem hiding this comment.
sorry @jeremy-jung1 can we change this to Back to Sign In Options to be consistent with the checkout login page? This is also something we agreed with Trevor on here
| <Button | ||
| onClick={() => setShowPasswordView(false)} | ||
| borderColor="gray.500" | ||
| color="blue.600" | ||
| variant="outline" | ||
| > | ||
| <FormattedMessage defaultMessage="Back to Sign In Options" id="login_form.button.back" /> |
There was a problem hiding this comment.
Sorry testing this again and I realized that this StandardLogin component is rendered differently for each of the 4 passwordless/social combination.
In the case where passwordless is disabled, the password field is shown so there's no need to display the back button.
I think we can simply make this button display when hideEmail is true
| @@ -28,7 +29,7 @@ const StandardLogin = ({ | |||
| handleForgotPasswordClick={handleForgotPasswordClick} | |||
| /> | |||
| </Stack> | |||
| <Stack spacing={6}> | |||
| <Stack spacing={2}> | |||
There was a problem hiding this comment.
I think this might affect the spacing for when social is enabled and passwordless is disabled and makes the Or Login With text + buttons closer than the figma design
spacing={2}:
I also actually think there's a bug in the spacing where spacing={6} makes the buttons too far:
Would you be able sneak in a spacing fix to ensure the buttons have a spacing of 4 but the "or Login With" keeps a spacing of 6
|
@jeremy-jung1 I followed the steps listed into the PR description. I can't find option for passwordless listed. Is the deployed successful? the nav can't be loaded. |
jeremy-jung1
merged commit c83473d
into
feature-passwordless-social-login
Description
Add back button to standard login modal/page after password login prompt
Types of Changes
Changes
How to Test-Drive This PR
Passwordless enabled
Passwordless disabled
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization