Convert to posix_spawn #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, this does not correctly turn on ECHO although for programs that set the term on their own (e.g., neovim), they run fine anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to properly call programs, especially ones that rely on standard input. It closes #5, closes #10, and closes #15.
However, it does not correctly reset the terminal mode when executing programs, which means that standard input is not echoed to the screen. I'm not sure why this is, since I'm pretty sure I'm doing it right, but whatever.
Programs such as neovim, that handle input and output in nonstandard ways, do work correctly.