Core: Implement the x64 calling convention resolver (msvc/gcc) #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gompoc
reviewed
Sep 2, 2024
| // If that's not possible, uncomment the binary type checks. | ||
| // This *will* break everything on x32. | ||
|
|
||
| const int ptrSize = 8; |
There was a problem hiding this comment.
Also available as: AppContext.Binary.PointerSize
There was a problem hiding this comment.
I know. X64 explicitly states the pointer size is going to be 8 bytes, so I hardcoded it as a constant to avoid unnecessary property gets and because declaring ptrSize outside of the resolution method would look better than if it was inside of it.
SamboyCoding
approved these changes
Sep 2, 2024
Pull Request Test Coverage Report for Build 10660949996Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I gave up on GCC ABI so this isn't perfect, but I left enough comments to (hopefully) make it clear for future myself. Waiting for a more elegant way to deal with true
structs in Cpp2IL.Core.Also made minor improvements in the x86 (I swear it must be called x64) instruction set.