Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibCpp2IL: Return empty array if number of read elements is 0 #345

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

commonuserlol
Copy link
Contributor

If length is 0, indexing array at 1 is an exception

FillReadableArrayHereNoLock(arr, 1);

Fixes #342

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11084184650

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 28.388%

Changes Missing Coverage Covered Lines Changed/Added Lines %
LibCpp2IL/Metadata/Il2CppMetadata.cs 1 2 50.0%
Totals Coverage Status
Change from base Build 11023494789: 0.005%
Covered Lines: 3342
Relevant Lines: 10041

💛 - Coveralls

@SamboyCoding SamboyCoding merged commit 0fc6a65 into SamboyCoding:development Sep 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2017.4.40f1 metadata cannot be read
3 participants