Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support emitting metadata for explicit interface implementations #346

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Support emitting metadata for explicit interface implementations #346

merged 1 commit into from
Oct 19, 2024

Conversation

ds5678
Copy link
Contributor

@ds5678 ds5678 commented Oct 19, 2024

Resolves #310

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11419860517

Details

  • 9 of 91 (9.89%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 28.24%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Cpp2IL.Core/OutputFormats/AsmResolverDummyDllOutputFormat.cs 0 1 0.0%
Cpp2IL.Core/Utils/AsmResolver/AsmResolverAssemblyPopulator.cs 0 31 0.0%
Cpp2IL.Core/Utils/AsmResolver/AsmResolverUtils.cs 8 58 13.79%
Files with Coverage Reduction New Missed Lines %
Cpp2IL.Core/OutputFormats/AsmResolverDummyDllOutputFormat.cs 1 0.0%
Cpp2IL.Core/Utils/AsmResolver/AsmResolverUtils.cs 1 3.54%
Totals Coverage Status
Change from base Build 11095420805: -0.1%
Covered Lines: 3350
Relevant Lines: 10098
💛 - Coveralls

@SamboyCoding SamboyCoding merged commit 3161f03 into SamboyCoding:development Oct 19, 2024
6 checks passed
@ds5678 ds5678 deleted the explicit-interface-implementations branch October 19, 2024 19:00
@ds5678 ds5678 mentioned this pull request Oct 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamboyCoding SamboyCoding SamboyCoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid interface method implementations
3 participants
@ds5678 @coveralls @SamboyCoding