[MPQEditor] Implement createFromDefaultExplorer #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayo09
reviewed
Apr 19, 2023
src/MPQEditor/MPQEditor.ts
Outdated
| @@ -47,6 +47,12 @@ export class MPQEditorProvider implements vscode.CustomTextEditorProvider { | |||
| } | |||
| ), | |||
| // Add command registration here | |||
| vscode.commands.registerCommand( | |||
| "one.editor.mpq.showFromDefaultExplorer", | |||
There was a problem hiding this comment.
May I ask why the command name is 'show*', as far as I understand, it should be 'createMPQJson'...? (THE SAME COMMENT TO #1529)
This commit implements createFromDefaultExplorer command for manual mixed precision task. ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <s.malakhov@partner.samsung.com>
stamalakhov
force-pushed
the
manual_MPQ_useCreateMPQJson_br
branch
from
5499f27 to
c46b253
Compare
stamalakhov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements createFromDefaultExplorer command for manual mixed precision task.
Its correctness is tested in #1511.
Fresh draft: #1511
Previous draft: #1505
Related: #1491
ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov s.malakhov@partner.samsung.com