Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onnx-subgraph initial CMakeLists.txt #14640

Closed
wants to merge 1 commit into from

Conversation

chenyx113
Copy link
Contributor

initial PR of onnx-subgraph tool.
related issue of: #14534
historical draft PR:
#14613

historical comments:
#14621 (comment)

#14630 (comment)

please check with historical full changes PR, thank you

ONE-DCO-1.0-Signed-off-by: Youxin Chen yx113.chen@samsung.com

@chenyx113 chenyx113 marked this pull request as ready for review February 12, 2025 00:45
@hseok-oh
Copy link
Contributor

Why you add CMakeLists.txt file on tools directory, not in new directory under tools for onnx-subgraph? (ex. tools/onnx-subgraph/CMakeLists.txt)

@hseok-oh
Copy link
Contributor

And your commit does not have any comment body. Please add body with signing.

@chenyx113
Copy link
Contributor Author

Why you add CMakeLists.txt file on tools directory, not in new directory under tools for onnx-subgraph? (ex. tools/onnx-subgraph/CMakeLists.txt)

yes,sorry for my mistake, I will submit again

@chenyx113 chenyx113 closed this Feb 12, 2025
@seanshpark
Copy link
Contributor

@chenyx113 , you are closing and add new PRs for some time.
I hope you can update commits, not closing.
Is there any problem with that?

@chenyx113
Copy link
Contributor Author

@chenyx113 , you are closing and add new PRs for some time. I hope you can update commits, not closing. Is there any problem with that?

ok, I will update based previous commit from now on.
no other problems, when I updating, I found current commits is behind master branch already, and rebase will introduce updating records in current PR, just want to have a clean screen for reviewing.

thanks for suggestion, I will follow it in future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants