[tools/onnx-subgraph] Add test model downloading scripts #14690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanshpark
reviewed
Feb 18, 2025
seanshpark
reviewed
Feb 18, 2025
seanshpark
reviewed
Feb 18, 2025
|
IMHO, it would be better to use |
ok, I will update as your comment after a while, thank you :) |
seanshpark
reviewed
Feb 18, 2025
seanshpark
reviewed
Feb 18, 2025
seanshpark
reviewed
Feb 18, 2025
seanshpark
reviewed
Feb 18, 2025
seanshpark
reviewed
Feb 18, 2025
seanshpark
reviewed
Feb 18, 2025
Add test onnx models downloading scripts for future smoking test ONE-DCO-1.0-Signed-off-by: Youxin Chen <yx113.chen@samsung.com>
modify the indent issue, remove useless code, add shebang in bash script, modify the typing mistake ONE-DCO-1.0-Signed-off-by: Youxin Chen <yx113.chen@samsung.com>
chenyx113
force-pushed
the
onnx-subgraph-0217
branch
from
7ebff35 to
950c2e4
Compare
chenyx113
changed the title
|
@seanshpark, thanks for your detail comments, I have updated as review, please help check |
seanshpark
reviewed
Feb 18, 2025
remove the pip install in the bash script ONE-DCO-1.0-Signed-off-by: Youxin Chen <yx113.chen@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #14534
historical PR:
#14654
#14613
Add test onnx models downloading scripts for future smoking test, downloading will happen in installing path, will not effect git status.
ONE-DCO-1.0-Signed-off-by: Youxin Chen yx113.chen@samsung.com