Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools/onnx-subgraph] add guide in README.md for subgraphs verification #14821

Merged
merged 4 commits into from
Mar 12, 2025

Conversation

chenyx113
Copy link
Contributor

related issue: #14534
historical full changes PR: #14613

guide for mse comparing of src model and multi sub models inference result

ONE-DCO-1.0-Signed-off-by: Youxin Chen yx113.chen@samsung.com

guide for mse comparing of src model and multi sub models

ONE-DCO-1.0-Signed-off-by: Youxin Chen <yx113.chen@samsung.com>
@chenyx113 chenyx113 marked this pull request as ready for review March 11, 2025 13:02
@@ -60,3 +60,18 @@ sub models.
├── NPUsubgraph0.onnx
└── NPUsubgraph1.onnx
```
## Verify the subgraphs inference with original model file
compare the MSE of original inference result and subgraphs inference result
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q) using indent (also in some other places in this file) will render as code block
is this intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is description, I have removed indent, thank you

-n scripts/subgraphs_ios.txt
```
output:
```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems text result, is it really needed to render as bash ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is log printing example, I have changed to text format, thank you

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK... I don't understand why render as bash but anyway you want it.

update as code review
update as code review
annotate for the shell printing
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit 57a4937 into Samsung:master Mar 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants