Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[luci] Add additional negative unit test for Reshape #14859

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

mbencer
Copy link
Contributor

@mbencer mbencer commented Mar 19, 2025

This commit adds additional unit test for negative scenario where "0" indicates not existing input dimension.

ONE-DCO-1.0-Signed-off-by: Mateusz Bencer m.bencer@partner.samsung.com

This commit adds additional unit test for negative scenario where "0" indicates not existing input dimension.

ONE-DCO-1.0-Signed-off-by: Mateusz Bencer <m.bencer@partner.samsung.com>
@seanshpark
Copy link
Contributor

Plz follow #14844 (comment) for this too

jinevening
jinevening previously approved these changes Mar 21, 2025
Copy link
Contributor

@jinevening jinevening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

seanshpark
seanshpark previously approved these changes Mar 21, 2025
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking again, doesn't need recipe for testing.
LGTM

@seanshpark
Copy link
Contributor

plz resolve conflict

@mbencer mbencer dismissed stale reviews from seanshpark and jinevening via c1334a5 March 21, 2025 07:27
@seanshpark seanshpark merged commit de81bb4 into Samsung:master Mar 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants