Use Aurum as backend instead of UIAutomator#44
Open
pwasowski2 wants to merge 37 commits intoSamsung:masterfrom
Open
Use Aurum as backend instead of UIAutomator#44pwasowski2 wants to merge 37 commits intoSamsung:masterfrom
pwasowski2 wants to merge 37 commits intoSamsung:masterfrom
Conversation
Implemented (with tests):
- findElOrEls (used by BaseDriver to implement all findElement*
commands, so they should all work now)
- {start, launch, close}App - new implementation using Aurum instead
of SDB was needed, because connection only works with apps launched
by Aurum
- isStartedApp
From now on, Aurum is the main and only backend used for communication between the Appium driver implemented in this repo and Tizen target. This commit removes support for the old backend (UIAutomator).
aurum.proto has changed. Among other changes, messages related to getAttribute() call were changed (see https://github.sec.samsung.net/tizen/aurum/issues/1 for details). This commit updates aurum.proto and getAttribute implementation to keep up with Aurum implementation. [Verification] getAttribute() tests in elm-demoo-tizen-mobile-test.js: 100 % pass rate
* Refactor tests - use chai asserts everywhere - use chai-as-promised asserts for promises - other, minor changes * Apply suggestions from code review Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <p.kosko@samsung.com> * Remove unnecessary parentheses Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <p.kosko@samsung.com>
* Refactor tests
- use chai asserts everywhere
- use chai-as-promised asserts for promises
- other, minor changes
* Apply suggestions from code review
Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <p.kosko@samsung.com>
* Remove unnecessary parentheses
* Implement getElement and getLocationInView with tests
* Implement get{Text, Enabled, Displayed, Selected, Size} and their tests
* Add missing elementSelected() test
* Fix parentheses
Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <p.kosko@samsung.com>
* Implement getProperty and its tests * Remove unnecessary import
* Fix calculation of Element's center position * Round returned coordinates
…Samsung#17) * Implement restarting Aurum bootstrap app on TizenDriver instantiation * Update lib/commands/general.js Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <p.kosko@samsung.com> Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <p.kosko@samsung.com>
* Update aurum.proto and auto-generated files * Implement getLocation and its tests
* Finish implementation of find* commands
* Fix findElement, add findElementId and fix tests
Appium requires findElement to return objects of the following form:
{
ELEMENT: <elementId>
}
This commit fixes findElement to fulfill this requirement, adds a
convenience method findElementId for writing unit tests and fixes
one of unit tests fixtures.
* Update README.md * Update README.md
* Implement touch{Up, Down, Move} commands
* Add links to specification. Reorder commands
* Make started sequence IDs stack TizenDriver's property
* Implement test for touch{Down, Move, Up}
* Implement click and touchLongClick
* Implement getting screen resolution
* Change TizenDriver.screenResolution property names
* Implement scrolling element into view
* Fix scrollElementIntoView and remove debug log
* Fix bugs scrollElementIntoView and add its tests
* Remove temporary folders after getting screen resolution
* Fix bugs click and add its tests
* Fix bugs in touchLongClick and add its tests
* Implement flick and its tests
* Add missing comments
* Implement setValue, setValueImmediate, replace and clear with tests
* Implement touch{Up, Down, Move} commands
* Add links to specification. Reorder commands
* Make started sequence IDs stack TizenDriver's property
* Implement test for touch{Down, Move, Up}
* Implement click and touchLongClick
* Implement getting screen resolution
* Change TizenDriver.screenResolution property names
* Implement scrolling element into view
* Fix scrollElementIntoView and remove debug log
* Fix bugs scrollElementIntoView and add its tests
* Remove temporary folders after getting screen resolution
* Fix bugs click and add its tests
* Fix bugs in touchLongClick and add its tests
* Implement flick and its tests
* Add missing comments
* Implement performTouch and its tests
* Implement back and its test
* Minor fixes in tests code
* Fix "-tizen aurum" requests factory * Reimplement touchLongClick to not use longClick() RPC
Some devices, in particular TVs, have /etc/config/model-config.xml's structure different than expected by the getScreenResolution() method from lib/tizen-helpers.js. getScreenResolution() won't work for these devices and throw an exception. We add an option to set resolution manually for these devices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes use of Aurum as the default and only backend for Appium automation on Tizen