Merged
Conversation
| horizontalArrangement = Arrangement.spacedBy(Theme.dimension.small) | ||
| ) { | ||
| statuses.forEachIndexed { index, status -> | ||
| val count = state.tasks.count { it.status == status } |
Contributor
There was a problem hiding this comment.
we didn't change any thing here , the filtering logic should be left to the view model this is not composable job
AimanYosofiUlt
requested changes
Jul 4, 2025
app/src/main/java/com/sanaa/tudee_assistant/presentation/utils/animation/AnimationExtensions.kt
Show resolved
Hide resolved
Contributor
|
For the animatetion i don't see any problem with it, i wrote you a comment that you may need to refactor in different PR |
shahad-97
previously approved these changes
Jul 4, 2025
shahad-97
approved these changes
Jul 4, 2025
AimanYosofiUlt
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Summary
feature animation
📌 Description
add animation to CategoryScreen
✅️Type of change
✅ Checklist:
developbranch🔍 Testing
Please check what has been verified before merging:
📎 Related Issues / Tasks
Link to any related issue or task:
#issue_number(if applicable)👥 Reviewers
Optional: Tag team members you want to review the changes
Example:
@teammate1@leadDev