Skip to content

Commit

Permalink
Set the parent of whatsnew correctly.
Browse files Browse the repository at this point in the history
Whatsnew's parent should be the mainwindow, not the gui manager. Also
whatsnew is not passing on its parent to the QDialog super class.
  • Loading branch information
jamescrake-merani committed Aug 23, 2024
1 parent d483235 commit fb93303
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/sas/qtgui/MainWindow/GuiManager.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def addWidgets(self):
self.GENSASCalculator = None
self.DataOperation = DataOperationUtilityPanel(self)
self.FileConverter = FileConverterWidget(self)
self.WhatsNew = WhatsNew(self)
self.WhatsNew = WhatsNew(self._parent)
self.regenProgress = DocRegenProgress(self)

def loadAllPerspectives(self):
Expand Down Expand Up @@ -661,7 +661,7 @@ def actionWelcome(self):
self.welcomePanel.show()

def actionWhatsNew(self):
self.WhatsNew = WhatsNew(strictly_newer=False)
self.WhatsNew = WhatsNew(self._parent, strictly_newer=False)
self.WhatsNew.show()

def showWelcomeMessage(self):
Expand Down
2 changes: 1 addition & 1 deletion src/sas/qtgui/Utilities/WhatsNew/WhatsNew.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class WhatsNew(QDialog):
"""
def __init__(self, parent=None, strictly_newer=True):
super().__init__()
super().__init__(parent)

self.setWindowTitle(f"What's New in SasView {sasview_version}")

Expand Down

0 comments on commit fb93303

Please sign in to comment.