Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exceptions with newer option #21

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Fix exceptions with newer option #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ All notable changes to this add-on will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
## Unreleased
### Fixed
- Fix exceptions using option introduced in previous version.

## [1.2.0] - 2023-10-19
- Ensure i18n resources are always initialized.
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/sasanlabs/fileupload/attacks/FileUploadAttackExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public FileUploadAttackExecutor(

public boolean executeAttack() throws FileUploadException {

Boolean shouldSendRequestsAfterFindingVulnerability =
boolean shouldSendRequestsAfterFindingVulnerability =
FileUploadConfiguration.getInstance().getSendRequestsAfterFindingVulnerability();

for (AttackVector attackVector : attackVectors) {
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/org/sasanlabs/fileupload/configuration/FileUploadConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public class FileUploadConfiguration extends VersionedAbstractParam {
private String parseResponseStartIdentifier;
private String parseResponseEndIdentifier;

private Boolean sendRequestsAfterFindingVulnerability;
private boolean sendRequestsAfterFindingVulnerability;

private static volatile FileUploadConfiguration fileUploadConfiguration;

Expand Down Expand Up @@ -109,7 +109,7 @@ public void setParseResponseEndIdentifier(String parseResponseEndIdentifier) {
parseResponseEndIdentifier);
}

public Boolean getSendRequestsAfterFindingVulnerability() {
public boolean getSendRequestsAfterFindingVulnerability() {
return sendRequestsAfterFindingVulnerability;
}

Expand Down Expand Up @@ -142,7 +142,7 @@ protected void parseImpl() {
this.setParseResponseEndIdentifier(
getConfig().getString(PARAM_PARSE_RESPONSE_CONFIGURATION_END_IDENTIFIER));
this.setSendRequestsAfterFindingVulnerability(
getConfig().getBoolean(PARAM_SEND_REQUESTS_AFTER_FINDING_VULNERABILITY_IDENTIFIER));
getBoolean(PARAM_SEND_REQUESTS_AFTER_FINDING_VULNERABILITY_IDENTIFIER, false));
}

@Override
Expand Down