chore(toast): Remove the toast crash fix to see what happens #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Don't merge yet
stavares843
changed the title
UI Automated Test Results Summary for MacOS/Windows534 tests 480 ✅ 3h 6m 47s ⏱️ Results for commit 3cebe24. ♻️ This comment has been updated with latest results. |
|
UI Automated Tests execution is complete! You can find the test results report here |
phillsatellite
approved these changes
Feb 28, 2024
dariusc93
approved these changes
Mar 1, 2024
dariusc93
added
Ready to Merge
stavares843
approved these changes
Mar 1, 2024
github-actions
bot
removed
QA Tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
The relevant merged PR for that is here fix(ToastNotification): Fix not crash app in chats page with Toast notifications activated #1665 which simply disables toasts for chat layout but does not actually fix the underlying issue.
We might need to dig into the underlying cause of that crash instead to fix it.
This is relevant for following PR:
#1877
#1876
where we want to show toasts in chat layout