Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Group): Fix crash on remove and add same member to the group #1886

Merged
merged 8 commits into from
Mar 4, 2024
Merged

fix(Group): Fix crash on remove and add same member to the group #1886

merged 8 commits into from
Mar 4, 2024

Conversation

lgmarchi
Copy link
Contributor

@lgmarchi lgmarchi commented Feb 28, 2024 •
edited
Loading

What this PR does 📖

1. Fix crash on remove and add same member to the group

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@lgmarchi lgmarchi self-assigned this Feb 28, 2024
@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Feb 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024 •
edited
Loading

UI Automated Test Results Summary for MacOS/Windows

514 tests   462 ✅  2h 58m 19s ⏱️
 44 suites   50 💤
  3 files      1 ❌  1 🔥

For more details on these failures and errors, see this check.

Results for commit e8b7944.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

@luisecm
Copy link
Contributor

luisecm commented Feb 28, 2024

We found the following issue on the automated test results:

  • After adding a user to Favorites, the heart button from the top is not refreshed and it's still showing Add To Favorites. Happening with normal chat and group chat
  • After removing a user from Favorites, the heart button from the top is not refreshed and it's still showing Remove from Favorites. Happening with normal chat and group chat
Grabacion.de.pantalla.2024-02-28.a.la.s.4.23.17.p.m.mov

@stavares843 stavares843 added the Changes requested When other dev or QA request a change label Feb 28, 2024
@lgmarchi
Copy link
Contributor Author

We found the following issue on the automated test results:

* After adding a user to Favorites, the heart button from the top is not refreshed and it's still showing Add To Favorites. Happening with normal chat and group chat

* After removing a user from Favorites, the heart button from the top is not refreshed and it's still showing Remove from Favorites. Happening with normal chat and group chat

Grabacion.de.pantalla.2024-02-28.a.la.s.4.23.17.p.m.mov

Fixed

@lgmarchi lgmarchi added Ready for testing Ready for QA to test and removed Changes requested When other dev or QA request a change labels Feb 29, 2024
@stavares843 stavares843 added QA Tested QA has tested and approved and removed Ready for testing Ready for QA to test labels Feb 29, 2024
@dariusc93
Copy link
Contributor

Does this also fix what #1885 is attempting to fix?

@github-actions github-actions bot removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Feb 29, 2024
@stavares843 stavares843 mentioned this pull request Feb 29, 2024
Closed
@stavares843
Copy link
Member

yes @dariusc93 ive closed that one instead

@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Mar 1, 2024
@dariusc93 dariusc93 added Ready to Merge This PR is ready to merge and removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Mar 4, 2024
@stavares843 stavares843 added Waiting for CI Waiting for at least one CI job to complete before merging and removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Mar 4, 2024
@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Mar 4, 2024
@stavares843 stavares843 merged commit 830f315 into dev Mar 4, 2024
8 of 10 checks passed
@stavares843 stavares843 deleted the avoid-crash-on-remove-and-add-memer branch March 4, 2024 20:09
@github-actions github-actions bot removed Failed Automated Test This PR is failing Luis's Appium test and needs revised Waiting for CI Waiting for at least one CI job to complete before merging labels Mar 4, 2024
@stavares843 stavares843 mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariusc93 dariusc93 dariusc93 approved these changes

@stavares843 stavares843 stavares843 approved these changes

@luisecm luisecm luisecm approved these changes

@phillsatellite phillsatellite phillsatellite approved these changes

Assignees

@lgmarchi lgmarchi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(groups): app crashes when adding back a user to a group chat
5 participants
@lgmarchi @luisecm @dariusc93 @stavares843 @phillsatellite