Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Profile): Add loading spinner on update profile info #1893

Merged
merged 8 commits into from
Mar 5, 2024

Conversation

lgmarchi
Copy link
Contributor

@lgmarchi lgmarchi commented Mar 1, 2024

What this PR does 📖

1. Add loading spinner on update profile info

image

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@lgmarchi lgmarchi self-assigned this Mar 1, 2024
@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Mar 1, 2024
@github-actions github-actions bot added the linter failing Cargo Workflow (linter) failed on this PR label Mar 1, 2024
Copy link
Contributor

github-actions bot commented Mar 1, 2024

UI Automated Test Results Summary for MacOS/Windows

534 tests   480 ✅  2h 58m 41s ⏱️
 45 suites   54 💤
  3 files      0 ❌

Results for commit 068890c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 1, 2024

UI Automated Tests execution is complete! You can find the test results report here

@lgmarchi lgmarchi added Ready for testing Ready for QA to test and removed linter failing Cargo Workflow (linter) failed on this PR labels Mar 4, 2024
@phillsatellite phillsatellite added Waiting for CI Waiting for at least one CI job to complete before merging QA Tested QA has tested and approved and removed Ready for testing Ready for QA to test Waiting for CI Waiting for at least one CI job to complete before merging labels Mar 4, 2024
@dariusc93 dariusc93 added Ready to Merge This PR is ready to merge and removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Mar 4, 2024
@stavares843 stavares843 added blocked and removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge labels Mar 4, 2024
@stavares843
Copy link
Member

waiting on feedback regarding UI

@lgmarchi
Copy link
Contributor Author

lgmarchi commented Mar 5, 2024

waiting on feedback regarding UI

Sara, if it is about my check. I just improved a little bit the code. And it's done this PR.

@stavares843 stavares843 merged commit 7fc0096 into dev Mar 5, 2024
10 checks passed
@stavares843 stavares843 deleted the add-loading-spinner-on-update-username branch March 5, 2024 14:14
@github-actions github-actions bot removed the blocked label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants