Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(CreateAccount): Add loading spinner on create a account #1895

Closed
wants to merge 1 commit into from

Conversation

lgmarchi
Copy link
Contributor

@lgmarchi lgmarchi commented Mar 4, 2024

What this PR does 📖

1. Add loading spinner on create a account

Screen.Recording.2024-03-04.at.11.55.54.mov

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@lgmarchi lgmarchi self-assigned this Mar 4, 2024
@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

UI Automated Test Results Summary for MacOS/Windows

502 tests   455 ✅  2h 46m 22s ⏱️
 39 suites   45 💤
  3 files      1 ❌  1 🔥

For more details on these failures and errors, see this check.

Results for commit 43605cd.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

UI Automated Tests execution is complete! You can find the test results report here

@lgmarchi
Copy link
Contributor Author

lgmarchi commented Mar 4, 2024

Matt prefers the other way, with loader in the button

@lgmarchi lgmarchi closed this Mar 4, 2024
@github-actions github-actions bot removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Mar 4, 2024
@stavares843 stavares843 deleted the add-loading-on-create-account branch April 12, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task(ui): Add loading indicator to Create Account
1 participant