Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(createAccount): Login loading indicator #1898

Merged
merged 9 commits into from
Mar 6, 2024
Merged

update(createAccount): Login loading indicator #1898

merged 9 commits into from
Mar 6, 2024

Conversation

lgmarchi
Copy link
Contributor

@lgmarchi lgmarchi commented Mar 4, 2024

What this PR does 📖

1. Login loading indicator

Screen.Recording.2024-03-04.at.14.59.03.mov

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@lgmarchi lgmarchi self-assigned this Mar 4, 2024
@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Mar 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024 •
edited
Loading

UI Automated Test Results Summary for MacOS/Windows

534 tests   480 ✅  3h 1m 33s ⏱️
 45 suites   54 💤
  3 files      0 ❌

Results for commit 50d1fce.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

@github-actions github-actions bot removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Mar 4, 2024
@github-actions github-actions bot added Failed Automated Test This PR is failing Luis's Appium test and needs revised and removed Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Mar 5, 2024
@phillsatellite phillsatellite added the QA Tested QA has tested and approved label Mar 5, 2024
@dariusc93 dariusc93 added Ready to Merge This PR is ready to merge and removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Mar 5, 2024
@stavares843 stavares843 added Waiting for CI Waiting for at least one CI job to complete before merging and removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge labels Mar 5, 2024
stavares843
stavares843 requested changes Mar 5, 2024
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when i click on the loader the app crashes

3842389238904.mov

no crash on dev

flow is

  • cargo run
  • add pin
  • click on the loader icon
  • crash

i don't a have a crash log on uplink just a apple log

message (14).txt

macOS, m1

@stavares843 stavares843 added Changes requested When other dev or QA request a change and removed Waiting for CI Waiting for at least one CI job to complete before merging labels Mar 5, 2024
@phillsatellite
Copy link
Contributor

Only was able to replicate 1 out of 10 tries but also got mine to crash as well same flow as Sara

@lgmarchi lgmarchi removed the Changes requested When other dev or QA request a change label Mar 6, 2024
@lgmarchi lgmarchi added the Ready for testing Ready for QA to test label Mar 6, 2024
@stavares843 stavares843 added Waiting for CI Waiting for at least one CI job to complete before merging and removed Ready for testing Ready for QA to test labels Mar 6, 2024
stavares843
stavares843 requested changes Mar 6, 2024
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the crash is fixed but on the create account gets stuck on the loader

tried 3x

works on dev

image

macOS, m1

@stavares843 stavares843 added Changes requested When other dev or QA request a change and removed Waiting for CI Waiting for at least one CI job to complete before merging labels Mar 6, 2024
stavares843
stavares843 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked now 🎉

@stavares843 stavares843 added Waiting for CI Waiting for at least one CI job to complete before merging and removed Changes requested When other dev or QA request a change labels Mar 6, 2024
@stavares843 stavares843 merged commit 2e23bfa into dev Mar 6, 2024
2 checks passed
@stavares843 stavares843 deleted the login_loading_indicator branch March 6, 2024 16:09
@github-actions github-actions bot removed the Waiting for CI Waiting for at least one CI job to complete before merging label Mar 6, 2024
@stavares843 stavares843 mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@stavares843 stavares843 stavares843 approved these changes

@dariusc93 dariusc93 dariusc93 approved these changes

Assignees

@lgmarchi lgmarchi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lgmarchi @phillsatellite @dariusc93 @stavares843 @Flemmli97