Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task(improvements): Improve chat modal styles #1903

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Conversation

Flemmli97
Copy link
Collaborator

What this PR does 📖

  • Centers checkbox for file share and did share modal
  • Reduce padding between chats in those modal
  • Make close button on modal have bigger gap to border

For the linked issue regarding:
Point 2.: Reason why it looks like top and bottom padding doesnt match is the div was scrolled.
Point 3.: For me the name was already aligned at the top together with the profile pic?

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

UI Automated Test Results Summary for MacOS/Windows

534 tests   480 ✅  3h 5m 43s ⏱️
 45 suites   54 💤
  3 files      0 ❌

Results for commit 26439d3.

Copy link
Contributor

github-actions bot commented Mar 6, 2024

UI Automated Tests execution is complete! You can find the test results report here

@phillsatellite phillsatellite added the QA Tested QA has tested and approved label Mar 6, 2024
@dariusc93 dariusc93 added Ready to Merge This PR is ready to merge and removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Mar 6, 2024
@stavares843 stavares843 merged commit 4c69090 into dev Mar 6, 2024
10 checks passed
@stavares843 stavares843 deleted the chat_modal_improv branch March 6, 2024 19:58
@github-actions github-actions bot removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge labels Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task(improvement): chat modal improvements
4 participants