Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Group): Prevent members from removing others #1906

Merged
merged 7 commits into from
Mar 8, 2024
Merged

fix(Group): Prevent members from removing others #1906

merged 7 commits into from
Mar 8, 2024

Conversation

lgmarchi
Copy link
Contributor

@lgmarchi lgmarchi commented Mar 6, 2024 •
edited
Loading

What this PR does 📖

1. Group non creators are not possible to remove other users, so removed the button remove from manage members, just let other users to add other users

2. On Manage members, added an indicator to show who is group creator

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@lgmarchi lgmarchi self-assigned this Mar 6, 2024
@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Mar 6, 2024
@dariusc93 dariusc93 added the Ready for testing Ready for QA to test label Mar 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

@phillsatellite phillsatellite added QA Tested QA has tested and approved and removed Ready for testing Ready for QA to test labels Mar 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024 •
edited
Loading

UI Automated Test Results Summary for MacOS/Windows

538 tests   491 ✅  3h 7m 2s ⏱️
 45 suites   47 💤
  3 files      0 ❌

Results for commit ddad76d.

♻️ This comment has been updated with latest results.

dariusc93
dariusc93 reviewed Mar 7, 2024
View reviewed changes
Copy link
Contributor

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment but besides that LGTM

ui/src/layouts/chats/presentation/chat/edit_group.rs Outdated Show resolved Hide resolved
lgmarchi added 2 commits March 7, 2024 10:46
@lgmarchi
Improve code
f03d73a
@lgmarchi
Merge remote-tracking branch 'origin/fix-group-creator-not-possible-t…
373da26 
…o-remove-other-users' into fix-group-creator-not-possible-to-remove-other-users
@stavares843 stavares843 mentioned this pull request Mar 7, 2024
Closed
@dariusc93 dariusc93 changed the title update(Group): Fix group non creator not possible to remove others fix(Group): Prevent members from removing others Mar 8, 2024
@dariusc93 dariusc93 added Ready to Merge This PR is ready to merge and removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Mar 8, 2024
@lgmarchi lgmarchi merged commit 0c722e2 into dev Mar 8, 2024
10 checks passed
@lgmarchi lgmarchi deleted the fix-group-creator-not-possible-to-remove-other-users branch March 8, 2024 12:40
@github-actions github-actions bot removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@stavares843 stavares843 stavares843 approved these changes

@dariusc93 dariusc93 dariusc93 approved these changes

Assignees

@lgmarchi lgmarchi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(groups): Non-creator of group cannot remove other users
4 participants
@lgmarchi @dariusc93 @stavares843 @phillsatellite