-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task(recovery): Redo seed enter recovery page #1915
Conversation
UI Automated Test Results Summary for MacOS/Windows527 tests 476 ✅ 3h 0m 56s ⏱️ For more details on these failures and errors, see this check. Results for commit b2c171c. ♻️ This comment has been updated with latest results. |
UI Automated Tests execution is complete! You can find the test results report here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what phil mentioned above
@Flemmli97 Automated tests failures on import account tests are expected on this PR since there is a change in the info text from the screen and also the layout is changing. I will push the corresponding test updates for this screen once that this PR is merged |
thanks @luisecm 🔨 |
Gravacao.do.ecra.2024-03-11.as.17.44.06.movif the seed is invalid, error appears as expected but the buttons are hidden unless you maximise the window |
Gravacao.do.ecra.2024-03-11.as.17.40.43.movthe toast is a bit cut off as well |
macOS, m1 |
ye i updated a translation text too to better reflect what the user now has to do |
hmm toast is supposed to look like that. but i guess it doesnt look too good |
yes i mean we can ignore the toast for now is possible to add a scroll or to make the default window size bigger? because when the error appears the user does not see the buttons as they are hidden cc @Flemmli97 |
What this PR does 📖
The phrases are now split into their own input. Typing enter will go to the next input unless the user is at the end where it will use act as the recovery button.
Copy pasting an input with the phrases split into new lines will auto paste them into their correct places.
E.g.
Having too many or incomplete phrases will only paste the relevant bits in.
Which issue(s) this PR fixes 🔨