Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Loader): Fix loader on buttons #1916

Merged
merged 7 commits into from
Mar 11, 2024

Conversation

lgmarchi
Copy link
Contributor

@lgmarchi lgmarchi commented Mar 8, 2024

What this PR does πŸ“–

1. Fix loader on buttons

Which issue(s) this PR fixes πŸ”¨

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@lgmarchi lgmarchi self-assigned this Mar 8, 2024
@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Mar 8, 2024
Copy link
Contributor

github-actions bot commented Mar 8, 2024

UI Automated Test Results Summary for MacOS/Windows

538 tests   491 βœ…β€ƒβ€ƒ3h 12m 2s ⏱️
 45 suites   47 πŸ’€
  3 files      0 ❌

Results for commit 49ffb62.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 8, 2024

UI Automated Tests execution is complete! You can find the test results report here

kit/src/elements/button/mod.rs Outdated Show resolved Hide resolved
kit/src/elements/button/mod.rs Outdated Show resolved Hide resolved
kit/src/elements/button/mod.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added linter failing Cargo Workflow (linter) failed on this PR and removed linter failing Cargo Workflow (linter) failed on this PR labels Mar 11, 2024
@dariusc93 dariusc93 added Ready for testing Ready for QA to test and removed Missing dev review Still needs to be reviewed by a dev labels Mar 11, 2024
@lgmarchi lgmarchi changed the title fix(Loader): Fix loader on buttons and inputs fix(Loader): Fix loader on buttons Mar 11, 2024
@stavares843 stavares843 merged commit 8647afe into dev Mar 11, 2024
20 of 28 checks passed
@stavares843 stavares843 deleted the fix-loader-on-add-and-remove-friends branch March 11, 2024 15:13
@github-actions github-actions bot removed Ready for testing Ready for QA to test Don't merge yet DO NOT MERGE labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(ui): update loading indicator when removing/blocking a friend
3 participants