-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Keybinds): Fix keybinds order when recording #1918
Conversation
UI Automated Test Results Summary for MacOS/Windows409 tests 376 ✅ 2h 42m 40s ⏱️ For more details on these failures and errors, see this check. Results for commit a071d8d. ♻️ This comment has been updated with latest results. |
UI Automated Tests execution is complete! You can find the test results report here |
@lgmarchi The automated test currently failing will need to be updated once that this PR is merged, since its expecting that when sending Alt + Ctrl + Shift + P, it will record Alt + Ctrl + Shift + P. Given the change from this PR, the new expected result should be Ctrl + Shift + Alt + P, regardless of the order of push, right? |
Perfect @luisecm, we will keep this pattern, I saw other apps, and we will follow always same order, independent of order user typed |
What this PR does 📖
1. Fix keybinds order when recording
Order of keybinds will be always like image above. Being "E" any other key is not modifier.
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤