Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(files): Resolve directory names for storage #1957

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

Flemmli97
Copy link
Collaborator

What this PR does 📖

  • Resolve directory names for storage in case it is related to a chat. This makes it so the directory doesn't display the chats uuid now and instead will display the chats name (if exist) or in case it is a direct message will display it as DM: <other participant>
  • The change is purely visual as the directory is still referred with the uuid under the hood

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Apr 2, 2024
Copy link
Contributor

github-actions bot commented Apr 2, 2024

UI Automated Test Results Summary for MacOS/Windows

507 tests   447 ✅  3h 0m 0s ⏱️
 44 suites   60 💤
  3 files      0 ❌

Results for commit c675851.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

UI Automated Tests execution is complete! You can find the test results report here

@phillsatellite
Copy link
Contributor

Noticed something odd while testing on MacOS. The names for 2 of the folders are still not appearing it seems like its probably the chat I have with Sara and WindowsPhill

Screenshot 2024-04-02 at 11 57 23 AM

@phillsatellite phillsatellite added the Changes requested When other dev or QA request a change label Apr 2, 2024
@Flemmli97
Copy link
Collaborator Author

Noticed something odd while testing on MacOS. The names for 2 of the folders are still not appearing it seems like its probably the chat I have with Sara and WindowsPhill

Screenshot 2024-04-02 at 11 57 23 AM

are those group chats or direct messages?

@phillsatellite
Copy link
Contributor

Noticed something odd while testing on MacOS. The names for 2 of the folders are still not appearing it seems like its probably the chat I have with Sara and WindowsPhill
Screenshot 2024-04-02 at 11 57 23 AM

are those group chats or direct messages?

Direct messages

@Flemmli97
Copy link
Collaborator Author

Noticed something odd while testing on MacOS. The names for 2 of the folders are still not appearing it seems like its probably the chat I have with Sara and WindowsPhill
Screenshot 2024-04-02 at 11 57 23 AM

are those group chats or direct messages?

Direct messages

can you try with the loggings of last commit and post the logs here?

on a different note:
should we simply display dms with only the other username instead of DM: username? simply cause it will show more of the name?

@phillsatellite
Copy link
Contributor

Noticed something odd while testing on MacOS. The names for 2 of the folders are still not appearing it seems like its probably the chat I have with Sara and WindowsPhill
Screenshot 2024-04-02 at 11 57 23 AM

are those group chats or direct messages?

Direct messages

can you try with the loggings of last commit and post the logs here?

on a different note: should we simply display dms with only the other username instead of DM: username? simply cause it will show more of the name?

sent in DM cause log file was too big to send in gh. And in regards to the DM: I think it kinda works as it is. If name gets cut off user can hover their cursor over it to reveal entire name. Maybe @XileHorizon might have a good design opinion about it

@phillsatellite
Copy link
Contributor

Noticed something odd while testing on MacOS. The names for 2 of the folders are still not appearing it seems like its probably the chat I have with Sara and WindowsPhill
Screenshot 2024-04-02 at 11 57 23 AM

are those group chats or direct messages?

Direct messages

can you try with the loggings of last commit and post the logs here?
on a different note: should we simply display dms with only the other username instead of DM: username? simply cause it will show more of the name?

sent in DM cause log file was too big to send in gh. And in regards to the DM: I think it kinda works as it is. If name gets cut off user can hover their cursor over it to reveal entire name. Maybe @XileHorizon might have a good design opinion about it

@XileHorizon had a really good idea. We should ditch the DM: part and just show username and then Kevin will get a new icon ready that we can add to differentiate between DM's and Groups. I can start a new ticket for the new folder icon Kevin will mock up

@Flemmli97
Copy link
Collaborator Author

Noticed something odd while testing on MacOS. The names for 2 of the folders are still not appearing it seems like its probably the chat I have with Sara and WindowsPhill
Screenshot 2024-04-02 at 11 57 23 AM

are those group chats or direct messages?

Direct messages

can you try with the loggings of last commit and post the logs here?
on a different note: should we simply display dms with only the other username instead of DM: username? simply cause it will show more of the name?

sent in DM cause log file was too big to send in gh. And in regards to the DM: I think it kinda works as it is. If name gets cut off user can hover their cursor over it to reveal entire name. Maybe @XileHorizon might have a good design opinion about it

@XileHorizon had a really good idea. We should ditch the DM: part and just show username and then Kevin will get a new icon ready that we can add to differentiate between DM's and Groups. I can start a new ticket for the new folder icon Kevin will mock up

that sounds good

@github-actions github-actions bot removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Apr 2, 2024
@Flemmli97
Copy link
Collaborator Author

decided it is fine as it is since the unnamed id folders might be due to deleted chats

@Flemmli97 Flemmli97 removed the Changes requested When other dev or QA request a change label Apr 4, 2024
@phillsatellite phillsatellite added the QA Tested QA has tested and approved label Apr 4, 2024
@dariusc93 dariusc93 added Ready to Merge This PR is ready to merge and removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Apr 5, 2024
@phillsatellite phillsatellite merged commit 0cbe129 into dev Apr 5, 2024
10 checks passed
@phillsatellite phillsatellite deleted the storage_directory_names branch April 5, 2024 16:10
@github-actions github-actions bot removed the QA Tested QA has tested and approved label Apr 5, 2024
@github-actions github-actions bot removed the Ready to Merge This PR is ready to merge label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task(files): Show chat names in the Chat_Media folder
4 participants