Merge pull request #689 from Satellite-im/luis/flakky-tests

test(update): fixes for flaky tests on CI

tests/screenobjects/chats/InputBar.ts

@@ -156,6 +156,8 @@ class InputBar extends UplinkMainScreen {
   async clickOnUploadFile() {
     const uploadButton = await this.uploadButton;
     await uploadButton.click();
+    const uploadButtonStorage = await this.uploadButtonStorage;
+    await uploadButtonStorage.waitForExist();
   }
 
   async generateRandomText() {
@@ -210,13 +212,15 @@ class InputBar extends UplinkMainScreen {
   }
 
   async selectUploadFromLocalDisk() {
-    await this.uploadButtonLocalDisk.waitForDisplayed();
-    await this.uploadButtonLocalDisk.click();
+    const uploadButtonLocalDisk = await this.uploadButtonLocalDisk;
+    await uploadButtonLocalDisk.waitForExist();
+    await uploadButtonLocalDisk.click();
   }
 
   async selectUploadFromStorage() {
-    await this.uploadButtonStorage.waitForDisplayed();
-    await this.uploadButtonStorage.click();
+    const uploadButtonStorage = await this.uploadButtonStorage;
+    await uploadButtonStorage.waitForExist();
+    await uploadButtonStorage.click();
   }
 
   async typeCodeOnInputBar(language: string, codeToType: string) {

tests/specs/04-friends.spec.ts

@@ -21,6 +21,7 @@ export default async function friendsTests() {
 
     // Go to Friends Screen
     await WelcomeScreen.goToFriends();
+    await FriendsScreen.waitForIsShown(true);
 
     // Validate Pre Release Indicator is displayed
     await FriendsScreen.releaseIndicator.waitForExist();

tests/specs/17-offline-requests.spec.ts

@@ -57,6 +57,7 @@ export default async function offlineRequestsTests() {
     await launchSecondApplication();
     await createNewUser(userB, true);
     await WelcomeScreen.goToFriends();
+    await FriendsScreen.waitForIsShown(true);
   });
 
   it("Offline Friend Requests - Send Friend Request to user #1", async () => {

tests/specs/reusable-accounts/05-message-attachments.spec.ts

@@ -161,10 +161,14 @@ export default async function messageAttachmentTests() {
     // Click on upload button and attach a file to compose attachment
     await InputBar.uploadFileFromLocalDisk("./tests/fixtures/testfile.txt");
 
-    // Validate contents on Compose Attachments are displayed
-    await ComposeAttachment.composeAttachmentsFileEmbed.waitForExist();
-    await ComposeAttachment.composeAttachmentsFileIcon.waitForExist();
-    await ComposeAttachment.composeAttachmentsFileNameText.waitForExist();
+    // Validate compose attachments displays the files to be uploaded before sending the message
+    await ComposeAttachment.validateComposeAttachmentsIsShown();
+
+    // Obtain the list of attachments added to Compose Attachment
+    await ComposeAttachment.validateAttachmentWithFileNameIsAdded(
+      "testfile.txt",
+      true,
+    );
   });
 
   it("Send Files on Chats - Delete attachment before sending the message", async () => {
@@ -176,8 +180,14 @@ export default async function messageAttachmentTests() {
     // Click on upload button and attach a file to compose attachment
     await InputBar.uploadFileFromLocalDisk("./tests/fixtures/testfile.txt");
 
-    // Validate contents on Compose Attachments are displayed
-    await ComposeAttachment.composeAttachmentsFileEmbed.waitForExist();
+    // Validate compose attachments displays the files to be uploaded before sending the message
+    await ComposeAttachment.validateComposeAttachmentsIsShown();
+
+    // Obtain the list of attachments added to Compose Attachment
+    await ComposeAttachment.validateAttachmentWithFileNameIsAdded(
+      "testfile.txt",
+      true,
+    );
 
     // Type a text message and send it
     await InputBar.typeMessageOnInput("Attached2");

tests/specs/reusable-accounts/06-chat-topbar.spec.ts

@@ -19,10 +19,14 @@ export default async function chatTopbarTests() {
     // Click on upload button and attach a file to compose attachment
     await InputBar.uploadFileFromLocalDisk("./tests/fixtures/testfile.txt");
 
-    // Validate contents on Compose Attachments are displayed
-    await ComposeAttachment.composeAttachmentsFileEmbed.waitForExist();
-    await ComposeAttachment.composeAttachmentsFileIcon.waitForExist();
-    await ComposeAttachment.composeAttachmentsFileNameText.waitForExist();
+    // Validate compose attachments displays the files to be uploaded before sending the message
+    await ComposeAttachment.validateComposeAttachmentsIsShown();
+
+    // Obtain the list of attachments added to Compose Attachment
+    await ComposeAttachment.validateAttachmentWithFileNameIsAdded(
+      "testfile.txt",
+      true,
+    );
 
     // Type a text message and send it
     await InputBar.typeMessageOnInput("Attached2");

tests/specs/reusable-accounts/07-quick-profile.spec.ts

@@ -119,6 +119,7 @@ export default async function quickProfileTests() {
   it("Chat User B - Ensure that Chat User B is not in friends list now", async () => {
     // Get current list of All friends and ensure that it does not include the removed user
     await WelcomeScreen.goToFriends();
+    await FriendsScreen.waitForIsShown(true);
     const allFriendsList = await FriendsScreen.getAllFriendsList();
     const includesFriend = await allFriendsList.includes("ChatUserA");
     await expect(includesFriend).toEqual(false);

tests/specs/reusable-accounts/08-sidebar-chats.spec.ts

@@ -169,6 +169,7 @@ export default async function chatsSidebarTests() {
 
     // Go to the current list of All friends and then open a Chat conversation with ChatUserA
     await WelcomeScreen.goToFriends();
+    await FriendsScreen.waitForIsShown(true);
     await FriendsScreen.validateChatWithFriendButtonIsShown();
     await FriendsScreen.hoverOnChatWithFriendButton("ChatUserA");
     await FriendsScreen.clickOnChatWithFriend();

tests/specs/reusable-accounts/12-group-chats-multiple-users.spec.ts

@@ -21,6 +21,7 @@ export default async function multipleUsersTests() {
     await launchThirdApplication();
     await CreatePinScreen.loginWithTestUser();
     await WelcomeScreen.goToFriends();
+    await FriendsScreen.waitForIsShown(true);
     await sendFriendRequestToUser("ChatUserA");
   });