Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IPv6 Infoblox tests #17340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix IPv6 Infoblox tests #17340

wants to merge 1 commit into from

Conversation

shubhamsg199
Copy link
Contributor

Fixing IPv6 Infoblox tests

  • Removing isc_dhcp as we don't really test it with infoblox integration and we don't document that as well
  • The domain created is already present in the IPv6 satellite hence adding condition to check first and create it if not present

@shubhamsg199
Fix ipv6 Infoblox test
6acf07e 
Signed-off-by: Shubham Ganar <sganar@redhat.com>
@shubhamsg199 shubhamsg199 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Jan 15, 2025
@shubhamsg199 shubhamsg199 self-assigned this Jan 15, 2025
@shubhamsg199 shubhamsg199 requested a review from a team as a code owner January 15, 2025 18:08
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_infoblox.py

ekohl
ekohl requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing isc_dhcp as we don't really test it with infoblox integration and we don't document that as well

👍 for that. It deserves its own test

Fixing IPv6 Infoblox tests

How can this fix IPv6 tests if the verification is still only verifying it creates an A record?

tests/foreman/destructive/test_infoblox.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dhcp_isc_package on line 23 is now also unused

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9890
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_infoblox.py --external-logging
Test Result : ================= 3 passed, 512 warnings in 3677.92s (1:01:17) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl requested changes

Assignees

@shubhamsg199 shubhamsg199

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubhamsg199 @Satellite-QE @ekohl