Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Customer Case]Reregister Host with removed consumer certs #17552

Merged
merged 5 commits into from
Feb 7, 2025
Merged

[Customer Case]Reregister Host with removed consumer certs #17552

merged 5 commits into from
Feb 7, 2025

Conversation

ColeHiggins2
Copy link
Member

Test for re-registering a host once consumer certs are removed

Customer Case for SAT-27875

@ColeHiggins2 ColeHiggins2 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.16.z Introduced in or relating directly to Satellite 6.16 labels Feb 7, 2025
@ColeHiggins2 ColeHiggins2 self-assigned this Feb 7, 2025
@ColeHiggins2 ColeHiggins2 requested a review from a team as a code owner February 7, 2025 15:47
chris1984
chris1984 reviewed Feb 7, 2025
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an assertion to make sure the certs are present after reregistering?

jeremylenz
jeremylenz reviewed Feb 7, 2025
View reviewed changes
tests/foreman/cli/test_host.py Outdated
function_ak_with_cv,
function_org,
):
"""Reregister a Host after cusumer certs have been removed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Reregister a Host after cusumer certs have been removed
"""Reregister a Host after consumer certs have been removed

@ColeHiggins2
Copy link
Member Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py::test_positive_reregister_rhel

vsedmik
vsedmik approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, PRT pending.

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10129
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py::test_positive_reregister_rhel --external-logging
Test Result : ================== 1 passed, 13 warnings in 914.22s (0:15:14) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 7, 2025
@vsedmik vsedmik merged commit 0fc34d8 into SatelliteQE:master Feb 7, 2025
11 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 7, 2025
@ColeHiggins2 @web-flow
[Customer Case]Reregister Host with removed consumer certs (#17552)
9815a6f 
* Add tests to reregister host

* remove extra pytestmarker for testing

* pre-commit checks

* add asserts for certs and key pem

* fix typo

(cherry picked from commit 0fc34d8)
@Satellite-QE Satellite-QE mentioned this pull request Feb 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris1984 chris1984 chris1984 approved these changes

@jeremylenz jeremylenz jeremylenz approved these changes

@vsedmik vsedmik vsedmik approved these changes

@damoore044 damoore044 damoore044 approved these changes

Assignees

@ColeHiggins2 ColeHiggins2

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ColeHiggins2 @Satellite-QE @chris1984 @jeremylenz @vsedmik @damoore044