Cooperative Refund + Lowball Broadcast #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael1011
reviewed
Apr 26, 2024
src/swaps/bitcoinv2.rs
Outdated
| pub fn broadcast( | ||
| &self, | ||
| signed_tx: &Transaction, | ||
| network_config: &ElectrumConfig, | ||
| is_lowball: Option<(&BoltzApiClientV2, Chain)>, |
There was a problem hiding this comment.
Lowball does not exist on the mainchain. You might want to keep the parameter for interface compatibility (not sure), but definitely ignore it in the function body. Or rename it to broadcast_via_boltz
There was a problem hiding this comment.
Just realised lowball does not exist for Bitcoin too. Removed lowball from Bitcoin broadcast and added a failure case for liquid if the chain == main..
|
We have hit a rate limit with codecov in the CI test. Ignoring the failure and merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Cooperative Refund for submarine swaps and Lowball transaction broadcasting.
Both of these can be tested using the test functions and extra test codes have been added to existing sites.
The lowball test code is commented out, as testing that requires manually changing the hard-coded tx fee to 0.01 sats/vb.