-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cooperative Refund + Lowball Broadcast #40
Conversation
src/swaps/bitcoinv2.rs
Outdated
pub fn broadcast( | ||
&self, | ||
signed_tx: &Transaction, | ||
network_config: &ElectrumConfig, | ||
is_lowball: Option<(&BoltzApiClientV2, Chain)>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lowball does not exist on the mainchain. You might want to keep the parameter for interface compatibility (not sure), but definitely ignore it in the function body. Or rename it to broadcast_via_boltz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realised lowball does not exist for Bitcoin too. Removed lowball from Bitcoin broadcast and added a failure case for liquid if the chain == main..
We have hit a rate limit with codecov in the CI test. Ignoring the failure and merging this. |
This PR adds the Cooperative Refund for submarine swaps and Lowball transaction broadcasting.
Both of these can be tested using the test functions and extra test codes have been added to existing sites.
The lowball test code is commented out, as testing that requires manually changing the hard-coded tx fee to 0.01 sats/vb.