Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change visibility of SwapResponse fields to public #44

Merged
merged 1 commit into from
May 10, 2024

Conversation

hydra-yse
Copy link
Contributor

This PR aims to fix a minor issue where the data returned by the get_pairs method is inaccessible by external libraries.

@michael1011 michael1011 requested a review from i5hi May 10, 2024 05:39
Copy link
Collaborator

@michael1011 michael1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I don't see a problem with exposing those

@i5hi
Copy link
Collaborator

i5hi commented May 10, 2024

Hey @hydra-yse, thanks for the PR!

Lint check is failing. Please run cargo fmt after making changes.

@i5hi
Copy link
Collaborator

i5hi commented May 10, 2024

Hey, I am about to start on some updates. Will just merge this for now and cargo fmt myself.

@hydra-yse Just take note of this for any successive PRs.

Thanks!

@i5hi i5hi closed this May 10, 2024
@i5hi i5hi reopened this May 10, 2024
@i5hi i5hi merged commit a7a9737 into SatoshiPortal:trunk May 10, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants