New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly return error on POST requests that fail with HTTP error code #50

Merged

i5hi merged 1 commit into SatoshiPortal:trunk from ok300:ok300-fix-post-error-mgmt-on-http-error-codes

Jun 6, 2024

Contributor

ok300 commented Jun 5, 2024

Before this PR, POST calls that would fail with an HTTP error code would be returned as Ok(error_message).

This PR consolidates error handling in post such that, in the case above, the method returns Err(Error::HTTP(error_message)).


          Correctly return error on POST requests that fail with HTTP error code

bd70eac

Collaborator

i5hi commented Jun 6, 2024

Thanks @ok300 !

i5hi merged commit feb17d3 into SatoshiPortal:trunk

4 checks passed

ok300 deleted the ok300-fix-post-error-mgmt-on-http-error-codes branch

June 6, 2024 18:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet