Skip to content

Comments

Character Verify Bugfix#89

Merged
freyamade merged 1 commit intomainfrom
verify-issue-fix
Jan 8, 2025
Merged

Character Verify Bugfix#89
freyamade merged 1 commit intomainfrom
verify-issue-fix

Conversation

@freyamade
Copy link
Member

  • Fixed a bug during the Character Verification process where it couldn't do cleanup, which first occurred yesterday.
  • For an explanation of the bug and what was done to fix it;
    • Previously, unverified Characters could not be used to make BIS Lists or join Teams or anything, so when you verified a Character the system would delete all the unverified versions of the same Character by Lodestone ID.
    • Now however, unverified Characters can be used for a week before everything gets deleted, but this caused a bug in the cleanup process where if an unverified version had a BIS List it couldn't be deleted.
    • Also, any proxies using the same Character get merged into the verified Character, consolidating all BIS Lists and Team Membership into the verified Character.
    • The fix I have implemented is to do this consolidation for un-verified Characters belonging to the same User as well, and leaving unverified versions owned by other Users to be deleted after the week deadline.
  • If anyone would like to share feedback / give ideas on this matter, please let me know on Github or in the Discord. Hopefully this is an acceptable solution!

@freyamade freyamade merged commit 27efc85 into main Jan 8, 2025
3 of 4 checks passed
@freyamade freyamade deleted the verify-issue-fix branch January 8, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant