Skip to content

Fix Local File Inclusion vulnerability. #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
s4l1h wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Local File Inclusion vulnerability. #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eabbc53
Fix Local File Inclusion vulnerability.
s4l1h Apr 30, 2020
93afedf
Update assets.js
s4l1h Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions server/routes/assets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,24 @@ import path from "path";
import fs from "fs";
const BASEPATH = process.env.BASEPATH;

// From: https://github.com/pillarjs/send/blob/master/index.js#L63
var UP_PATH_REGEXP = /(?:^|[\\/])\.\.(?:[\\/]|$)/;

const assets = (req, res) => {
let filePath = req.originalUrl;

try {
filePath = decodeURIComponent(filePath);
} catch (err) {
return res.status(403).send(new Error("invalid url"));
}
if (~filePath.indexOf("\0")) {
return res.status(403).send(new Error("null byte attack dedected!!"));
}
if (UP_PATH_REGEXP.test(filePath)) {
return res.status(403).send(new Error("LFI attack dedected!!!"));
}

if (BASEPATH) {
filePath = req.originalUrl.replace(`/${BASEPATH}`, ``);
}
Expand Down