-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sean inventory #148
Open
s-j-cunningham
wants to merge
4
commits into
main
Choose a base branch
from
sean-inventory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sean inventory #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this PR would break functionality in the frontend, I think it's best to hold off on this until we demo. Is that alright? |
Yes that is definitely fine. Realistically it's not even required. If we were going to keep improving this app over a longer period it's something we would want, but if we don't want to spend FE time making changes for this that's fine by me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to Test
Postman:
Change Summary
Updated the pantry update inventory endpoint so that it automatically checks whether a food exists in the food table and adds it if it doesn't. Also updated the route from /pantries/:pantry_id/:food_id to /pantries/:pantry_id/:food_name as new foods do not have a food_id.
Updated existing test and added a new test.
Developer Checklist