Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotnet releases-index to include new supported-os field. #3927

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

leecow
Copy link
Contributor

@leecow leecow commented Jul 17, 2024

.NET is now producing a supported-os.json file that is referenced in releases-index.json. This update adds the new field to the schema.

dotnet/core#9294

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@madskristensen
Copy link
Contributor

@leecow there was an issue with the test run

@leecow
Copy link
Contributor Author

leecow commented Jul 18, 2024

@madskristensen - I presume it's complaining because the new property definition is in the updated schema definition but not in the 'production' latest.json? Does the latest.json update need to follow the schema update?

@madskristensen
Copy link
Contributor

@leecow yes, the tests files are always validated against the schema matching the file path

Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale PR is stale and will be closed in 7 days(auto-generated by stale action) label Sep 17, 2024
Copy link
Member

@hyperupcall hyperupcall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just had one question

Edit: It looks like CI fails, that needs to be fixed as well

"support-phase"
],
"additionalProperties": false
}
},
"description": "A collection of manifests for .NET products, which is updated with each preview and stable release of the .NET SDK and/or Runtime",
"id": "https://json.schemastore.org/dotnet-releases-index.json",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this was removed? At at SchemaStore, schemas must have the id properly if they are draft-04 or $id if they are any other draft level.

@github-actions github-actions bot removed the Stale PR is stale and will be closed in 7 days(auto-generated by stale action) label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants