-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dotnet releases-index to include new supported-os field. #3927
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
for more information, see https://pre-commit.ci
@leecow there was an issue with the test run |
@madskristensen - I presume it's complaining because the new property definition is in the updated schema definition but not in the 'production' latest.json? Does the latest.json update need to follow the schema update? |
@leecow yes, the tests files are always validated against the schema matching the file path |
This PR is stale because it has been open 60 days with no activity. Comment or this will be closed in 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just had one question
Edit: It looks like CI fails, that needs to be fixed as well
"support-phase" | ||
], | ||
"additionalProperties": false | ||
} | ||
}, | ||
"description": "A collection of manifests for .NET products, which is updated with each preview and stable release of the .NET SDK and/or Runtime", | ||
"id": "https://json.schemastore.org/dotnet-releases-index.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason this was removed? At at SchemaStore, schemas must have the id
properly if they are draft-04
or $id
if they are any other draft level.
.NET is now producing a supported-os.json file that is referenced in releases-index.json. This update adds the new field to the schema.
dotnet/core#9294