# 127 Certification 도메인 개발 #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimTaeO
reviewed
Nov 13, 2023
| @Column(columnDefinition = "VARCHAR(30)", nullable = false) | ||
| val name: String, | ||
|
|
||
| @Column(columnDefinition = "DATETIME(6)", nullable = false) |
There was a problem hiding this comment.
학생활동 파트를 이미 끝내버리고 나서 든 생각인데 활동 날짜와 같이 이것도 취득일자 이기 때문에 정확한 시간이 필요하지 않아보여요 그래서 DATE 데이터 타입을 사용하는걸 고려해보는게 어떨까요
There was a problem hiding this comment.
d2f1376 LocalDate 로 적용해봤습니다!
KimTaeO
approved these changes
Nov 13, 2023
esperar
reviewed
Nov 13, 2023
Comment on lines
19
to
21
| @ManyToOne(fetch = FetchType.LAZY) | ||
| @JoinColumn(name = "user_id", columnDefinition = "BINARY(16)") | ||
| val user: User, |
There was a problem hiding this comment.
ERD에서는 연관관계가 student랑 되어있습니다 헷갈리신거같은데 수정 부탁드려요
esperar
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 개요
Certification 도메인 개발
📃 작업내용
Certification Entity 생성
Certification Repository 생성